abstractdog commented on code in PR #6793:
URL: https://github.com/apache/hive/pull/6793#discussion_r4216294766
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -261,7 +261,8 @@ public OrcEncodedDataReader(LowLevelCache lowLevelCache,
BufferUsageManager buff
}
consumer.setUseDecimal64ColumnVectors(HiveConf.getVar(jobConf,
-
ConfVars.HIVE_VECTORIZED_INPUT_FORMAT_SUPPORTS_ENABLED).equalsIgnoreCase("decimal_64"));
+ ConfVars.HIVE_VECTORIZED_INPUT_FORMAT_SUPPORTS_ENABLED)
+
.equalsIgnoreCase(HiveConf.HIVE_VECTORIZED_INPUT_FORMAT_SUPPORTS_DECIMAL_64));
Review Comment:
ack, doing it! might be a follow-up, but this change is obvious, I don't
mind if it makes the patch bigger a bit
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -261,7 +261,8 @@ public OrcEncodedDataReader(LowLevelCache lowLevelCache,
BufferUsageManager buff
}
consumer.setUseDecimal64ColumnVectors(HiveConf.getVar(jobConf,
-
ConfVars.HIVE_VECTORIZED_INPUT_FORMAT_SUPPORTS_ENABLED).equalsIgnoreCase("decimal_64"));
+ ConfVars.HIVE_VECTORIZED_INPUT_FORMAT_SUPPORTS_ENABLED)
+
.equalsIgnoreCase(HiveConf.HIVE_VECTORIZED_INPUT_FORMAT_SUPPORTS_DECIMAL_64));
Review Comment:
ack, doing it now! might be a follow-up, but this change is obvious, I don't
mind if it makes the patch bigger a bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
