zabetak commented on code in PR #6900: URL: https://github.com/apache/hive/pull/6900#discussion_r4335805994
########## serde/src/java/org/apache/hadoop/hive/serde2/OpenCSVSerde.java: ########## Review Comment: Consider for example the `JsonSerDe` which serializes and deserializes values to JSON. For primitive types, I guess the conversion to CSV and JSON should be similar (if not identical). By aligned I mean that if we serialize a TIMESTAMP type in a certain way in CSV should it should be roughly the same with the JSON. It would be awkward to serialize a timestamp as a String in one place and as an integer (epoch seconds) in another place. Apart from `JsonSerDe` there are a few other implementations so overall I wanted to ensure that what we do here is consistent with the rest of Hive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
