thomasrebele commented on code in PR #6900: URL: https://github.com/apache/hive/pull/6900#discussion_r4338266948
########## serde/src/java/org/apache/hadoop/hive/serde2/OpenCSVSerde.java: ########## Review Comment: It's the other way round, the code was broken when vectorization is off. I think it is better to keep the OpenCSVSerde output the same Strings (except for the byte[] fix), for backward compatibility. As far as I could see in the code, that can be achieved by `toString` on the result of `getPrimitiveWritableObject(field)`. Speaking in the wheel analogy: I didn't invent the wheel, it was already there. I just made it a bit rounder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
