zabetak commented on code in PR #6900: URL: https://github.com/apache/hive/pull/6900#discussion_r4337396145
########## serde/src/java/org/apache/hadoop/hive/serde2/OpenCSVSerde.java: ########## Review Comment: I am not suggesting a refactoring just asking for a sanity check that there are not conceptual differences on how we handle conversions. I used JSON only as an example. My comment was mainly to see if there is similar conversion code implemented elsewhere so that we don't reinvent the wheel. If the answer is no then that's good with me and we can move on. On the surface, this may seem like a small bug fix for vectorization but in practice it starts making `OpenCSVSerde` an actually useful feature. If the code was broken when vectorization is on then it means that this feature was for the most part unused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
