Aggarwal-Raghav commented on code in PR #6938:
URL: https://github.com/apache/hive/pull/6938#discussion_r4459443570
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/handler/BaseHandler.java:
##########
@@ -153,8 +153,16 @@ public abstract class BaseHandler extends FacebookBase
implements IHMSHandler {
protected MetaStoreFilterHook filterHook;
protected boolean isServerFilterEnabled = false;
+ // ======================== FaceBookBase ===================================
+ private String name_;
Review Comment:
I understand the need for 1:1 copy of FacebookBase for existing behaviour,
but since this code will now be owned by Hive
1. These C++ naming conventions which sonar has flagged can be flagged?
2. Use CAS based increment counter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
