dengzhhu653 commented on PR #6938:
URL: https://github.com/apache/hive/pull/6938#issuecomment-6904629300

   > Inlining `FacebookBase` into `BaseHandler` removes 
`com.facebook.fb303.FacebookBase` itself, and some `ThriftHiveMetastore.Iface` 
implementers extend it directly: waggle-dance's 
[`FederatedHMSHandler`](https://github.com/ExpediaGroup/waggle-dance/blob/main/waggle-dance-core/src/main/java/com/hotels/bdp/waggledance/server/FederatedHMSHandler.java)
 and metacat's 
[`CatalogThriftHiveMetastore`](https://github.com/Netflix/metacat/blob/master/metacat-thrift/src/main/java/com/netflix/metacat/thrift/CatalogThriftHiveMetastore.java).
 They would have to re-add libfb303 0.9.3, which brings back its 
`FacebookService` classes, built for libthrift 0.9.3, next to the 0.24 ones 
generated from `fb303.thrift`. Could `FacebookBase.java` stay as a source file 
in metastore-common under its original package, as in 
[#6653](https://github.com/apache/hive/pull/6653/changes/8aadf78fcb00d69d2bfa307568df68dd63cf5428)?
 `BaseHandler` can keep extending it.
   
   Thanks for the comment, @slachiewicz!
   My take is we don't need this abstract `FacebookService` class if we don't 
break any clients, the ThriftHiveMetastore.Iface has extended 
FacebookService.Iface, the new ThriftHiveMetastore.Iface handler must implement 
all the functions declared in FacebookService or extends the Hive `BaseHandler` 
if they upgraded to 4.3.0, so no surprise for the client.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to