InvisibleProgrammer commented on code in PR #6938:
URL: https://github.com/apache/hive/pull/6938#discussion_r4480840481
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/handler/BaseHandler.java:
##########
@@ -127,7 +129,7 @@
/**
* This class serves as the super class for all handlers that implement the
IHMSHandler
*/
-public abstract class BaseHandler extends FacebookBase implements IHMSHandler {
+public abstract class BaseHandler implements IHMSHandler {
Review Comment:
I assuming this change is about picking up the code from FacebookBase and
copying into this class so that fb303 can be removed. Am I correct?
If I am correct, are we still need fb303 at all?
I'm thinking about this:
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/thrift/fb303.thrift
I only kept it to keep the compatibility and being able to remove fb303
completely later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
