abstractdog commented on code in PR #6953:
URL: https://github.com/apache/hive/pull/6953#discussion_r4563551713


##########
.github/workflows/precommit-image.yml:
##########
@@ -49,23 +49,44 @@ jobs:
         uses: actions/checkout@v6
         with:
           persist-credentials: false
+          # On a PR, HEAD is the PR merged into its target branch, and HEAD^1 
is the target branch.
+          fetch-depth: 2
 
-      - name: Check that the tag is not published yet
+      # A published tag is never overwritten. When the tag is published 
already, a change of the
+      # Dockerfile needs a new version; any other change (e.g. of this 
workflow) does not publish.
+      - name: Check the tag

Review Comment:
   I agree it's overcomplicated; we shall iterate one more time before merging
   what tag do you think the Jenkinsfile should contain: `latest` or pin to a 
specific timestamp?
   
   1. "do not have to manually bump the version every time" makes me think that 
the `Jenkinsfile` should always contain `latest`, in this case 1 PR per change 
is enough, `latest` will point to a certain timestamp tag
   
   2. 2 PRs per change: a) first one is approved, merged, b) github action 
deploys an image tag `20261113133625-commithash` c) follow-up PR bumps 
`Jenkinsfile` to the newer
   
   does it make sense?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to