abstractdog commented on code in PR #6953:
URL: https://github.com/apache/hive/pull/6953#discussion_r4584916377
##########
.github/workflows/precommit-image.yml:
##########
@@ -49,23 +49,44 @@ jobs:
uses: actions/checkout@v6
with:
persist-credentials: false
+ # On a PR, HEAD is the PR merged into its target branch, and HEAD^1
is the target branch.
+ fetch-depth: 2
- - name: Check that the tag is not published yet
+ # A published tag is never overwritten. When the tag is published
already, a change of the
+ # Dockerfile needs a new version; any other change (e.g. of this
workflow) does not publish.
+ - name: Check the tag
Review Comment:
ack, a tiny inconsistency is acceptable
let me pick the right method for now; I'll let you know
> we cannot really control which version of the hive-ci-runner:latest will
be used in the same CI run.
right this is acceptable, the testing should be done manually from custom
docker image, which is possible by the `IMAGE` parameter anyway: it needs
jenkins access now, not a problem I think
##########
.github/workflows/precommit-image.yml:
##########
@@ -49,23 +49,44 @@ jobs:
uses: actions/checkout@v6
with:
persist-credentials: false
+ # On a PR, HEAD is the PR merged into its target branch, and HEAD^1
is the target branch.
+ fetch-depth: 2
- - name: Check that the tag is not published yet
+ # A published tag is never overwritten. When the tag is published
already, a change of the
+ # Dockerfile needs a new version; any other change (e.g. of this
workflow) does not publish.
+ - name: Check the tag
Review Comment:
ack, a tiny inconsistency is acceptable
let me pick the right method for now; I'll let you know
> we cannot really control which version of the hive-ci-runner:latest will
be used in the same CI run.
right this is acceptable, the testing should be done manually from custom
docker image, which is possible by the `IMAGE` parameter anyway: it needs
jenkins access now, not a problem I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]