zabetak commented on code in PR #6953:
URL: https://github.com/apache/hive/pull/6953#discussion_r4583913520
##########
.github/workflows/precommit-image.yml:
##########
@@ -49,23 +49,44 @@ jobs:
uses: actions/checkout@v6
with:
persist-credentials: false
+ # On a PR, HEAD is the PR merged into its target branch, and HEAD^1
is the target branch.
+ fetch-depth: 2
- - name: Check that the tag is not published yet
+ # A published tag is never overwritten. When the tag is published
already, a change of the
+ # Dockerfile needs a new version; any other change (e.g. of this
workflow) does not publish.
+ - name: Check the tag
Review Comment:
Any of the two publish schemes is fine with me and both have their own
advantages/disadvantages. The approach on `latest` is definitely simpler for
deployment and publishing but less ideal for version tracking, stability, and
security.
I cannot really make up my mind so we could go for the simplest one at this
point and see if we want to revisit the publishing model in the future. One
small caveat that comes to mind is that the action will publish the new image
once the commit reaches master. Since there is no ordering between GitHub
actions and Jenkins runs we cannot really control which version of the
`hive-ci-runner:latest` will be used in the same CI run. I guess that updating
the image will not be so frequent so a tiny bit of inconsistency may be
acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]