Kimahriman opened a new pull request, #3035:
URL: https://github.com/apache/datafusion-comet/pull/3035
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Related to #174, not full support so probably should keep that open (or open
new tickets specifically for column mapping and deletion vectors)
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Delta scans are simply built-in Parquet scans when column mapping and
deletion vectors are not used, so the existing Comet parquet scans work fine
for them. This adds support for these cases in the scan rule and adds some unit
tests that could be used for future integration of delta-rs or delta-kernel-rs
for full scan support.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Updates the `CometScanRule` to use Comet parquet scans for Delta V1 scans of
tables that don't use column mapping or deletion vectors. Adds a new
`DeltaReflection` class for accessing the Delta properties to determine the
enabled features.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Adds unit tests for different Delta scans and adds Delta as.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
