Dandandan commented on code in PR #19622:
URL: https://github.com/apache/datafusion/pull/19622#discussion_r2662671140
##########
datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs:
##########
@@ -564,6 +566,7 @@ fn test_pushdown_through_aggregates_on_grouping_columns() {
// 2. An outer filter (b@1 = bar) above the aggregate - also gets pushed
through because 'b' is a grouping column
let scan = TestScanBuilder::new(schema()).with_support(true).build();
+ #[expect(deprecated)]
Review Comment:
I think the current state is fine - they can go once (in future)
`CoalesceBatchesExec` is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]