jizezhang commented on code in PR #19616: URL: https://github.com/apache/datafusion/pull/19616#discussion_r2667351133
########## datafusion/execution/src/cache/list_files_cache.rs: ########## @@ -146,9 +149,12 @@ pub const DEFAULT_LIST_FILES_CACHE_MEMORY_LIMIT: usize = 1024 * 1024; // 1MiB /// The default cache TTL for the [`DefaultListFilesCache`] pub const DEFAULT_LIST_FILES_CACHE_TTL: Option<Duration> = None; // Infinite +#[derive(PartialEq, Eq, Hash, Clone, Debug)] +pub struct TableScopedPath(pub Option<TableReference>, pub Path); Review Comment: Hi @BlakeOrth @alamb , regarding making a generic `ScopedPath<S>`, it seems to me that we would need to carry the generic parameter `S` to `CacheAccessor<ScopedPath<S>, ...>`, and to `ListFilesCache<S>` and then to `CacheManager<S>`? or there might be cleaner way to make it generic? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
