BlakeOrth commented on code in PR #19616: URL: https://github.com/apache/datafusion/pull/19616#discussion_r2669664797
########## datafusion/execution/src/cache/list_files_cache.rs: ########## @@ -146,9 +149,12 @@ pub const DEFAULT_LIST_FILES_CACHE_MEMORY_LIMIT: usize = 1024 * 1024; // 1MiB /// The default cache TTL for the [`DefaultListFilesCache`] pub const DEFAULT_LIST_FILES_CACHE_TTL: Option<Duration> = None; // Infinite +#[derive(PartialEq, Eq, Hash, Clone, Debug)] +pub struct TableScopedPath(pub Option<TableReference>, pub Path); Review Comment: This suggestion was mostly a "nice to have" if it ended up being very simple. I don' think it's strictly necessary and it sounds like it did not end up being simple! I don't think it's worth the additional complexity since the generic parameter would need to be propagated so far. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
