BlakeOrth commented on code in PR #19616:
URL: https://github.com/apache/datafusion/pull/19616#discussion_r2669680968
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1327,12 +1329,34 @@ impl SessionContext {
&& table_provider.table_type() == table_type
{
schema.deregister_table(&table)?;
+ if table_type == TableType::Base {
+ self.drop_list_files_cache_entries(&table_ref,
&table_provider);
Review Comment:
I personally feel like the looping strategy in the most recent commits is
probably adequate until proven otherwise. Dropping tables should be occurring
much less frequently than querying tables (at least in most normal usage), so
in that sense it doesn't seem like it's in the "critical path" for performance.
It seems to me that it's probably better to keep the implementation that is
more simple and maintainable for the time being.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
