alamb commented on code in PR #19716:
URL: https://github.com/apache/datafusion/pull/19716#discussion_r2695178937
##########
datafusion/physical-expr-adapter/src/schema_rewriter.rs:
##########
@@ -473,6 +477,141 @@ impl<'a> DefaultPhysicalExprAdapterRewriter<'a> {
}
}
+/// Factory for creating [`BatchAdapter`] instances to adapt record batches
Review Comment:
Sounds good to me -- maybe we can also update the SchemaAdapter deprecation
note to refer to this new structure too
https://github.com/apache/datafusion/blob/75d2473ba76c9791e9ff5f8f0d04bfa7e55274f5/datafusion/datasource/src/schema_adapter.rs#L80-L83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
