adriangb commented on PR #19716: URL: https://github.com/apache/datafusion/pull/19716#issuecomment-3745309753
> unfortunately it is slightly more than just casting(applying default values, unifying schemas, etc), we doing some RB->RB modification just after the scan, hopefully we can do this better in future as this part is expensive. from my investigation in https://github.com/apache/datafusion-comet/pull/3047 it seemed like you might need something like this for [iceberg_scan.rs](https://github.com/apache/datafusion-comet/pull/3047/changes#diff-27951e320c82df451a7cf90739656a62c3e9c6244f4a6717f0cef39a49850172) but the defaults, unifying schemas, etc. should all be handled by `PhysicalExprAdapter` (`SparkPhysicalExprAdapterFactory` for you), but you don't need to do any stream mapping with that, you pass it into `FileScanConfigBuilder::with_expr_adapter` and it applies it to the stream. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
