adriangb commented on code in PR #19716:
URL: https://github.com/apache/datafusion/pull/19716#discussion_r2687135315
##########
datafusion/physical-expr-adapter/src/schema_rewriter.rs:
##########
@@ -473,6 +477,141 @@ impl<'a> DefaultPhysicalExprAdapterRewriter<'a> {
}
}
+/// Factory for creating [`BatchAdapter`] instances to adapt record batches
Review Comment:
Yes agreed, I give my reasoning in
https://github.com/apache/datafusion/pull/19716#issuecomment-3729967773 but
TLDR is it would be hard / impossible to replicate the exact semantics and APIs
of `SchemaAdapter` so any sort of un-deprecated version would only be half
functional and probably cause more headache than it's worth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
