> He said he didn't feel strongly, and obviously I implemented it this way so I 
> at least feel more strongly. But point taken.

I'm not really saying either way is better per se, but you said you didn't care 
much, and he asked you to change it 
(https://github.com/geany/geany/pull/1212#issuecomment-245685550).  As the 
discussion reads from here, it *looks* like you ignored it.
Same with showing the plugin name in the warning 
(https://github.com/geany/geany/pull/1212#r77622584) -- probably a mere 
forgetfulness, though.

I'm not trying to blame or try and stop people from going ahead with merges, 
just trying to smooth things out and get everyone happy :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1212#issuecomment-247564169

Reply via email to