> As the discussion reads from here, it looks like you ignored it.

I kind of did ignore it, because as I understood what he meant was to use 
`g_error()` or alike and crash Geany, which sounded kind of harsh/insane. This 
was possibly a misunderstanding on my part though. Since it was such a trivial 
patch and the number of people who will encounter this code path so small, I 
figured I'd just make an "executive decision" so to speak.

> Same with showing the plugin name in the warning (#1212 (comment)) -- 
> probably a mere forgetfulness, though.

That was indeed forgetfulness (or rather misreading), I missed your comment 
when reviewing the comments before merging.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1212#issuecomment-247566056

Reply via email to