> Clearly you don't accidentally checkout an old version over your changes as 
> often as I do :(​

It won't, well at least Git won't allow you to change branches with modified 
files, also Geany wouldn't lose your changes unless the buffer was clean. If it 
the buffer was clean, just use Undo to restore the previous version. Your 
changes are as safe as they are at present.

> I don't think it should stop this PR since the problem exists even if you 
> manually allow reload a few times

The difference is currently you have to manually (or in my case accidentally 
manually) reload, whereas if you have a file written to often (like multiple 
times per second) like the log file example, or even just switching VCS 
branches while many files are open a bunch of times, the memory will grow out 
of control much faster. As someone who tends to leave a single Geany instance 
running for a week or more at a time, this is a real concern.

> But PRs are welcome to disable reload undo per document.​

IIRC this was rejected when the confirmation was removed from Reload and we 
started copying the whole buffer on each reload into the undo history.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1246#issuecomment-249746594

Reply via email to