@js361014 I havn't looked at your code yet to judge its competence, but your social competence leaves something to be desired. To just come into a project and say "here, this is the way it should be done, throw away your existing features" is not the way to get engagement in a diverse group of contributors.
Some like @kugel- will like it, some like me will think its ok sometimes, but have alternative suggestions (like expanding the toolbar search facility instead of using space in the editor, which you havn't addressed yet), and some will dislike it like @codebrainz. You need to make a case, and just saying "its the way browsers do it" isn't particularly persuasive when talking about an IDE. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2220#issuecomment-515850573
