Am 30. Juli 2019 01:14:57 MESZ schrieb Matthew Brush <[email protected]>: >@js361014 my only issue with the actual change is that it doesn't >include the Search and Replace, so now there's different UIs for normal >find (dialog, search bar, toolbar) and Replace (dialog) and Find In >Files (dialog).
True, in my view the bar would entirely replace the dialog (which is driving me nuts on my 3 monitor setup), i.e. the dialog ui would move into the bar, probably with some tweaks. I wouldn't except yet another search UI if it cannot fully replace an existing one. > >Other than that I'm just unclear why this has to go into core instead >of a plugin like would normally be done. I'd like to hear from some >other core devs whether we're going to start bringing in additions to >core which could/should go in plugins. @b4n @eht16 @frlan @ntrel? Its always a case-by-case discussion, there is no general rule that every enhancement that can possibly be implemented in a plugin must be implemented in a plugin. The author would rather see it in the core so thats what he has spent his time on. I support him in this case because I hate the dialog and the "offload small but useful features to fire-and-forget plugins" methodology in general. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2220#issuecomment-516268372
