> I just tried and on my other linux VM geanylua with the PR runs with Lua 5.4 > without any modifications needed.
I saw that note. The problem is the Lua language changes between versions. And there may be subtle API differences that work fine on the C side, but result in different Lua execution results. So if different platforms are using different versions of Lua, say 5.3 and 5.4, the scripts won't necessarily be compatible. Also, existing Lua 5.1 scripts may break. > I'm not really convinced by the performance argument - I just don't see how > anyone would notice. The whole Geany except Scintilla lexers and ctags > parsers could be written in a scripting language and I don't think anyone > would notice any performance difference. Whether someone notices depends on how performant their hardware is. I've seen Geany touted as being suitable for use on low-end hardware. At least a few such users would notice. > ... by adding JIT you make from a nice little interpreter a beast which > introduces its own set of problems like CPU/OS/architecture dependence. I'm > not sure how LuaJIT's JIT works but since most of the scripts will be > short-running, it could make the execution of the scripts slower if it > performs JIT compilation every time and doesn't store the precompiled binary > somewhere. LuaJIT can run without JIT (as I understand, this is the default). According to benchmarks others have run, the LuaJIT interpreter, without JIT, runs faster than the Lua interpreter. > I suspect users of this plugin will use it for smaller utilities related to > their workflow and they won't use any advanced features from the language > where they might see differences. Based on code snippets posted online, changes in Lua behavior can be surprising. Even if something breaking is unlikely, it would be highly disruptive to the workflows of users who do experience problems. If not using advanced features, why switch to Lua 5.4 rather than add LuaJIT build support? > Anyway, my personal preference would be using pure Lua but I'm fine if others > have a different opinion and the LuaJIT patch gets merged. Adding LuaJIT build support now doesn't in and of itself block work toward supporting another Lua release in the future. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1133#issuecomment-1455268327 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/issues/1133/[email protected]>
