@eht16 commented on this pull request.
>
# write tags
script_dir = dirname(__file__)
tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags')
- with open(tags_file_path, 'w') as tags_file:
+ with open(tags_file_path, 'w', encoding='iso-8859-1') as tags_file:
The content parsed from the JSON is (probably) just ASCII. But the `TA_*`
markers are not ASCII and are encoded in `iso-8859-1`, also for other files
using this tagmanager format.
I just added it on writing the file to explicitly set it, as Python3 `open()`
wants the `encoding` argument.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3488#discussion_r1190417531
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3488/review/[email protected]>
