@eht16 commented on this pull request.
>
# write tags
script_dir = dirname(__file__)
tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags')
- with open(tags_file_path, 'w') as tags_file:
+ with open(tags_file_path, 'w', encoding='iso-8859-1') as tags_file:
It does not. Tried it and the resulting file is identical.
In the generating script we had to use byte strings for writing to the binary
yopened file and need to encode the generated tag line anyway.
So, I guess the remaining difference could be performance, maybe the one is
0.5ms faster than other. For me, the difference cannot be big enough to care if
the script is executed every few years :).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3488#discussion_r1192799069
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3488/review/[email protected]>
