@elextr commented on this pull request.
>
# write tags
script_dir = dirname(__file__)
tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags')
- with open(tags_file_path, 'w') as tags_file:
+ with open(tags_file_path, 'w', encoding='iso-8859-1') as tags_file:
All the symbols are ASCII and tagmanager only uses a few low byte values (which
are valid ASCII) IIRC so I guess the encoding won't matter for this purpose.
When PHP adds emoji to its symbols it might be different :stuck_out_tongue:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3488#discussion_r1192884242
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3488/review/[email protected]>
