The condition is wrong and for version 2.0 it will constantly report 
there's an update available when upgrading from 1.x (where x > 0).

I had a "visionary" moment regarding possible 2.0 problems and had a 
look at the updatechecker plugin if it handles major versions - id does, but 
wrongly (in addition, there are two identical conditions for the 
"minor" version but the "mini" version check is missing).

I haven't tested this at all (not sure how to test when there's no 
actual release).

@b4n @eht16 I think this or some other variant of this patch should go to 2.0.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/1284

-- Commit Summary --

  * updatechecker: Fix logic comparing version numbers

-- File Changes --

    M updatechecker/src/updatechecker.c (22)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/1284.patch
https://github.com/geany/geany-plugins/pull/1284.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1284
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/[email protected]>

Reply via email to