@b4n approved this pull request.

LGTM (not tested)

Indeed the check is wrong in many aspects -- event 0.0.2 would be < then 1.38.1
Also, it uses `GEANY_VERSION`, which is a compile-time thing, so better update 
your update checker!  It could benefit from Geany exposing 
`main_get_version_string()` or similar (but probably not under that name).



-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1284#pullrequestreview-1682590419
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1284/review/1682590...@github.com>

Reply via email to