> Indeed the check is wrong in many aspects -- event 0.0.2 would be < then > 1.38.1
Here you'll be saved by the copy-paste error of the current code where the last digit is ignored ;-). The current code won't behave as bad as I thought originally because for releases the value on the server is the highest number. It would be just in the meantime, like now, where we already have 2.0 and server says 1.38 and for the code 1.38 > 2.0. Anyway, better to fix and also handle the last digit of the version. > Also, it uses GEANY_VERSION, which is a compile-time thing, so better update > your update checker! It could benefit from Geany exposing > main_get_version_string() or similar (but probably not under that name). Yeah, but hopefully most of the time users update geany+plugins at the same time. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1284#issuecomment-1766739854 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/1284/[email protected]>
