With this, you should be able to build *src/* and *plugins/* warning-free with `CFLAGS="-Wall -Wextra -g -Og -Wno-unused-parameter -Wunreachable-code -Wformat=2 -Wundef -Wshadow -Wpointer-arith -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -Werror-implicit-function-declaration"` (or just `-Wall -Wextra -g -Og -Wno-unused-parameter -Wwrite-strings` to start with) but for some Lexilla prototype and one deprecated Lexilla call.
To review, go per-commit as it should be fairly trivial that way. Also, everything but maybe 12b30c5950eeccad2fed885745ff6cd0888d1d3a should not be controversial I think -- but please, raise any concern! You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3665 -- Commit Summary -- * Fix harmless GCC warning * Fix fairly nasty implicit integer conversion * "Fix" passing const arguments to spawn functions * Add casts for irrelevant -Wwrite-strings warnings * Remove invalid placeholder code * Use g_*list_free_full() instead of g_*list_foreach() * Avoid an easy-to-fix function cast * Silence warnings on appropriate GSourceFunc casts * Fix variable shadowing * Only pass literals as format strings for e.g. printf-style functions * Do not use GtkResponseType as response ID type * Silence some -Wcast-function-type warnings -- File Changes -- M plugins/filebrowser.c (12) M plugins/splitwindow.c (2) M src/build.c (40) M src/dialogs.c (5) M src/document.c (27) M src/editor.c (2) M src/filetypes.c (3) M src/libmain.c (16) M src/notebook.c (14) M src/plugins.c (14) M src/printing.c (4) M src/search.c (10) M src/spawn.c (10) M src/symbols.c (2) M src/tagmanager/tm_ctags.c (2) M src/tagmanager/tm_workspace.c (7) M src/toolbar.c (5) M src/ui_utils.c (35) M src/utils.h (4) M src/vte.c (10) -- Patch Links -- https://github.com/geany/geany/pull/3665.patch https://github.com/geany/geany/pull/3665.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3665 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/[email protected]>
