@elextr approved this pull request.
Gold star to @b4n, one suggestion for extra points.
>
if (main_status.main_window_realized)
- dialogs_show_msgbox(GTK_MESSAGE_WARNING, warn_msg,
display_filename);
+ dialogs_show_msgbox(GTK_MESSAGE_WARNING, "%s",
warn_msg);
+
+ ui_set_statusbar(TRUE, "%s", warn_msg);
Maybe the format should be taken out of `ui_set_statusbar` and
`msgwin_status_add` or the compiler told they are
[formats](https://gcc.gnu.org/onlinedocs/gcc-3.2/gcc/Function-Attributes.html)
[and](https://releases.llvm.org/9.0.0/tools/clang/docs/AttributeReference.html#format).
Note this is passed through printf substitution here, in `ui_set_statusbar()`
and `msgwin_status_add()` called from that.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3665#pullrequestreview-1703112755
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3665/review/[email protected]>
