@techee commented on this pull request.
> {
+ GeanyDocument *doc = document_get_current();
+
+ if (plugin_extension_goto_provided(doc, NULL))
+ return plugin_extension_goto_perform(doc, pos, definition);
> there's still the question of whether this should really be guarded behind
> Geany thinking there's a word. IMO it shouldn't, and callers should stop
> being guarded behind it, and the perform() call should return FALSE if
> there's no word to act on. This would alleviate the artificial dependency on
> Geany dictating there's a word -- but not actually providing it.
Completely agree - it should be the plugin's decision regardless of what Geany
itself considers to be the necessary condition for the goto to be performed.
I'll modify the code accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3849#discussion_r1635475740
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3849/review/[email protected]>
