@b4n commented on this pull request.
>
if (plugin_extension_goto_provided(doc, NULL))
return plugin_extension_goto_perform(doc, pos, definition);
+ editor_find_current_word(doc->editor, pos,
+ editor_info.current_word, GEANY_MAX_WORD_LENGTH, NULL);
+ name = *editor_info.current_word ? editor_info.current_word : NULL;
+
Any reason not to include the `if (! name) return FALSE;`? Apparently
`goto_tag()` seems NULL-safe, but we'll still end up with updating the
statusbar with a message including a NULL representation.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3849#pullrequestreview-2111553908
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3849/review/[email protected]>