eerhardt commented on a change in pull request #7032:
URL: https://github.com/apache/arrow/pull/7032#discussion_r416111304
##########
File path: csharp/src/Apache.Arrow/Arrays/PrimitiveArrayBuilder.cs
##########
@@ -162,8 +188,8 @@ public TBuilder Swap(int i, int j)
public TArray Build(MemoryAllocator allocator = default)
{
return Build(
- ValueBuffer.Build(allocator), ArrowBuffer.Empty,
- ValueBuffer.Length, 0, 0);
+ ValueBuffer.Build(allocator),
ValidityBuffer.Build(allocator).ValueBuffer,
Review comment:
> That said, Build could easily pass an empty buffer if NullCount == 0.
Yes that would work well. It is what the C++ implementation does:
https://github.com/apache/arrow/blob/3064a27cf284726ce08b98b14725b2f9d7ef5ea2/cpp/src/arrow/array.cc#L59-L62
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
