zgramana commented on a change in pull request #7032:
URL: https://github.com/apache/arrow/pull/7032#discussion_r416116593
##########
File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs
##########
@@ -48,21 +48,28 @@ public BinaryArray(ArrowTypeId typeId, ArrayData data)
data.EnsureBufferCount(3);
}
- public abstract class BuilderBase<TArray, TBuilder> :
IArrowArrayBuilder<byte, TArray, TBuilder>
+ public abstract class BuilderBase<T, TArray, TBuilder> :
IArrowArrayBuilder<T, TArray, TBuilder>
+ where T: struct
where TArray : IArrowArray
- where TBuilder : class, IArrowArrayBuilder<byte, TArray, TBuilder>
+ where TBuilder : class, IArrowArrayBuilder<T, TArray, TBuilder>
{
+
protected IArrowType DataType { get; }
protected TBuilder Instance => this as TBuilder;
protected ArrowBuffer.Builder<int> ValueOffsets { get; }
- protected ArrowBuffer.Builder<byte> ValueBuffer { get; }
+ protected ArrowBuffer.Builder<T> ValueBuffer { get; }
+ protected BooleanArray.Builder ValidityBuffer { get; }
+
protected int Offset { get; set; }
+ protected int ValidityOffset { get; set; }
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
