zgramana commented on a change in pull request #7032:
URL: https://github.com/apache/arrow/pull/7032#discussion_r416165482
##########
File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs
##########
@@ -48,21 +48,28 @@ public BinaryArray(ArrowTypeId typeId, ArrayData data)
data.EnsureBufferCount(3);
}
- public abstract class BuilderBase<TArray, TBuilder> :
IArrowArrayBuilder<byte, TArray, TBuilder>
+ public abstract class BuilderBase<T, TArray, TBuilder> :
IArrowArrayBuilder<T, TArray, TBuilder>
Review comment:
Early on in the effort I was trying to get a more generalized
BuilderBase, and one that could be more easily re-used by end users (such as
myself) who might be interested in implementing a custom type. It didn't really
end working out that way, however, so I have reverted it back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
