bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417347149
##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -270,19 +425,20 @@ cdef class FileSystemDataset(Dataset):
CFileSystemDataset* filesystem_dataset
def __init__(self, paths_or_selector, schema=None, format=None,
- filesystem=None, partitions=None, root_partition=None):
+ filesystem=None, partitions=None, root_partition=_true):
Review comment:
Okay, I'll coerce `None` to `_true` in the function body. If you'd
prefer that we don't coerce `None` expressions to `_true` in python at all,
we'll need to expose and use C++ overloads which don't accept an expression (so
the coercion can happen in C++), but that seems less preferred to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
