bkietz commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417340605
##########
File path: cpp/src/arrow/type.cc
##########
@@ -43,6 +43,49 @@
#include "arrow/visitor_inline.h"
namespace arrow {
+
+constexpr Type::type NullType::type_id;
Review comment:
This is ensuring that `/\w+Type::type_id/` is a defined symbol in
`libarrow.so`. Previously these have only been used within a translation unit
which links into `libarrow.so`, but now I'm using them in filter.cc which gets
linked to `libarrow_dataset.so`. If you remove these you'll find the linker
emits an error because they're undefined in `libarrow.so`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
