eerhardt commented on a change in pull request #7032:
URL: https://github.com/apache/arrow/pull/7032#discussion_r418392155
##########
File path: csharp/test/Apache.Arrow.Tests/BooleanArrayTests.cs
##########
@@ -48,13 +48,13 @@ public void AppendsExpectedBit()
.Append(false)
.Build();
- Assert.False(array1.GetBoolean(0));
+ Assert.False(array1.GetValue(0).GetValueOrDefault());
Review comment:
I don't think this is a correct change. `GetValueOrDefault()` will
return `false` when the value is really `null`. So if `GetValue(0)` returned
`null`, it would be wrong but this test would still pass. Instead I would call
`.Value` here because we want to fail if it is `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
