eerhardt commented on a change in pull request #7032:
URL: https://github.com/apache/arrow/pull/7032#discussion_r418394280



##########
File path: csharp/src/Apache.Arrow/Arrays/ArrayData.cs
##########
@@ -53,6 +60,26 @@ public sealed class ArrayData : IDisposable
             Offset = offset;
             Buffers = buffers;
             Children = children;
+
+            if (NullCount == RecalculateNullCount)
+            {
+                Recalculate();
+            }
+        }
+
+        private int Recalculate()

Review comment:
       No one is capturing this return value.
   
   I would suggest leaving this code alone in this PR (it is large enough 
already). We can fix this case in a separate, dedicated PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to