zgramana commented on a change in pull request #7032:
URL: https://github.com/apache/arrow/pull/7032#discussion_r418417744
##########
File path: csharp/test/Apache.Arrow.Tests/BooleanArrayTests.cs
##########
@@ -48,13 +48,13 @@ public void AppendsExpectedBit()
.Append(false)
.Build();
- Assert.False(array1.GetBoolean(0));
+ Assert.False(array1.GetValue(0).GetValueOrDefault());
Review comment:
With the new builder behavior of setting NullCount to 0 and passing an
empty buffer when null isn’t present, the Assert.Null calls in these tests fail
because the IsValid check always returns true. These particular tests are not
appending null values.
I opted to move them to the new GetValue method as GetBoolean is deprecated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
