fsaintjacques commented on a change in pull request #7180:
URL: https://github.com/apache/arrow/pull/7180#discussion_r428250038
##########
File path: cpp/src/arrow/dataset/file_parquet.cc
##########
@@ -163,124 +158,47 @@ static std::shared_ptr<Expression>
ColumnChunkStatisticsAsExpression(
less_equal(field_expr, scalar(max)));
}
-static Result<std::shared_ptr<Expression>> RowGroupStatisticsAsExpression(
- const parquet::RowGroupMetaData& metadata,
- const parquet::ArrowReaderProperties& properties) {
- ARROW_ASSIGN_OR_RAISE(auto manifest, GetSchemaManifest(metadata,
properties));
-
- ExpressionVector expressions;
- for (const auto& schema_field : manifest.schema_fields) {
- expressions.emplace_back(ColumnChunkStatisticsAsExpression(schema_field,
metadata));
+static std::shared_ptr<Expression> RowGroupStatisticsAsExpression(
+ const parquet::RowGroupMetaData& metadata, const SchemaManifest& manifest)
{
+ const auto& fields = manifest.schema_fields;
+ ExpressionVector expressions{fields.size()};
Review comment:
I keep getting caught by this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
