fsaintjacques commented on a change in pull request #7180:
URL: https://github.com/apache/arrow/pull/7180#discussion_r428677725
##########
File path: cpp/src/parquet/arrow/reader_internal.cc
##########
@@ -747,8 +747,7 @@ Status TypedIntegralStatisticsAsScalars(const Statistics&
statistics,
using CType = typename StatisticsType::T;
return MakeMinMaxScalar<CType, StatisticsType>(statistics, min, max);
default:
- return Status::NotImplemented("Cannot extract statistics for type ",
- logical_type->ToString());
+ return Status::NotImplemented("Cannot extract statistics for type ");
Review comment:
KISS, we should just extend MakeMinMaxScalar to support the other types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
