fsaintjacques commented on a change in pull request #7180:
URL: https://github.com/apache/arrow/pull/7180#discussion_r428250624
##########
File path: cpp/src/arrow/dataset/file_parquet.cc
##########
@@ -315,20 +233,28 @@ class ParquetScanTaskIterator {
}
ParquetScanTaskIterator(std::shared_ptr<ScanOptions> options,
- std::shared_ptr<ScanContext> context,
- std::vector<int> column_projection, RowGroupSkipper
skipper,
- std::unique_ptr<parquet::arrow::FileReader> reader)
+ std::shared_ptr<ScanContext> context, FileSource
source,
+ std::unique_ptr<parquet::arrow::FileReader> reader,
+ std::vector<int> column_projection,
+ std::vector<RowGroupInfo> row_groups)
: options_(std::move(options)),
context_(std::move(context)),
+ source_(std::move(source)),
+ reader_(std::move(reader)),
column_projection_(std::move(column_projection)),
- skipper_(std::move(skipper)),
- reader_(std::move(reader)) {}
+ row_groups_(std::move(row_groups)) {}
std::shared_ptr<ScanOptions> options_;
std::shared_ptr<ScanContext> context_;
- std::vector<int> column_projection_;
- RowGroupSkipper skipper_;
+
+ FileSource source_;
Review comment:
For debug purposes, this is extremely useful to introspect the object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
