kou commented on a change in pull request #7388:
URL: https://github.com/apache/arrow/pull/7388#discussion_r437795928
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -1879,13 +1879,19 @@ macro(build_zstd)
add_dependencies(toolchain zstd_ep)
add_dependencies(ZSTD::zstd zstd_ep)
+ set(ZSTD_LIBRARIES ZSTD::zstd)
endmacro()
if(ARROW_WITH_ZSTD)
resolve_dependency(ZSTD)
+ # "SYSTEM" source will prioritize cmake config, which exports
+ # zstd::libzstd_{static,shared}
+ if(TARGET zstd::libzstd_static)
+ set(ZSTD_LIBRARIES zstd::libzstd_static)
Review comment:
OK.
We use static library for vendored libraries and shared library for external
libraries. If we use static library for external libraries, we provide an
option to use static library and the option is off by default. e.g.
`ARROW_BOOST_USE_SHARED` is `ON` by default:
https://github.com/apache/arrow/blob/master/cpp/cmake_modules/DefineOptions.cmake#L278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
