tobim commented on a change in pull request #7388:
URL: https://github.com/apache/arrow/pull/7388#discussion_r438140636
##########
File path: cpp/cmake_modules/FindZSTD.cmake
##########
@@ -65,4 +66,5 @@ if(ZSTD_FOUND)
set_target_properties(ZSTD::zstd
PROPERTIES IMPORTED_LOCATION "${ZSTD_LIB}"
INTERFACE_INCLUDE_DIRECTORIES
"${ZSTD_INCLUDE_DIR}")
+ set(ZSTD_LIBRARIES ZSTD::zstd)
Review comment:
Why do you introduce this extra indirection? The target could just as
well be renamed to `zstd::libzstd_{shared,static}` depending on
`ARROW_ZSTD_USE_SHARED`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
