tobim commented on a change in pull request #7388:
URL: https://github.com/apache/arrow/pull/7388#discussion_r438399869
##########
File path: cpp/cmake_modules/FindZSTD.cmake
##########
@@ -65,4 +66,5 @@ if(ZSTD_FOUND)
set_target_properties(ZSTD::zstd
PROPERTIES IMPORTED_LOCATION "${ZSTD_LIB}"
INTERFACE_INCLUDE_DIRECTORIES
"${ZSTD_INCLUDE_DIR}")
+ set(ZSTD_LIBRARIES ZSTD::zstd)
Review comment:
I was thinking of something like
```cmake
if(ZSTD_FOUND)
if(ARROW_ZSTD_USE_SHARED)
set(ZSTD_TARGET zstd::libzstd_shared)
else()
set(ZSTD_TARGET zstd::libzstd_static)
endif()
add_library(${ZSTD_TARGET} UNKNOWN_IMPORTED)
set_target_properties(${ZSTD_TARGET}
PROPERTIES IMPORTED_LOCATION "${ZSTD_LIB}"
INTERFACE_INCLUDE_DIRECTORIES
"${ZSTD_INCLUDE_DIR}")
endif()
```
The intention is to align the interface of `FindZSTD` with the exported
targets file from upstream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
