martindurant commented on a change in pull request #7395:
URL: https://github.com/apache/arrow/pull/7395#discussion_r438137975



##########
File path: python/pyarrow/tests/test_fs.py
##########
@@ -511,7 +545,8 @@ def test_get_file_info(fs, pathfn):
     assert 'aaa' in repr(aaa_info)
     assert aaa_info.extension == ''
     assert 'FileType.Directory' in repr(aaa_info)
-    assert aaa_info.size is None
+    # TODO fsspec gives a size for directories

Review comment:
       The size is indeed the file-size on disc - local files are stored as one 
or more blocks. For remote filesystems, and especially object stores or other 
emulated directories, this will be zero.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to