jorisvandenbossche commented on a change in pull request #7395:
URL: https://github.com/apache/arrow/pull/7395#discussion_r443585915
##########
File path: python/pyarrow/tests/test_dataset.py
##########
@@ -1117,6 +1115,15 @@ def test_open_dataset_from_uri_s3(s3_connection,
s3_server):
with fs.open_output_stream("mybucket/data.parquet") as out:
pq.write_table(table, out)
+ return table, path, fs, uri, host, port, access_key, secret_key
Review comment:
I would personally prefer to keep the unpacking, otherwise that will
make the rest of the code IMO less readable.
To ensure we are talking about the same, you would propose to do like this?
```
...
dataset = ds.dataset(s3_example_simple.path, format="parquet",
filesystem=s3_example_simple.fs)
...
```
(or with a shorter alias for ``s3_example_simple``)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
